Skip to content

feat(ramp): add navigateToRampBuy helper and refactor useRampNavigation#29924

Draft
amitabh94 wants to merge 1 commit into
mainfrom
feat/ramp-navigate-to-buy-foundation
Draft

feat(ramp): add navigateToRampBuy helper and refactor useRampNavigation#29924
amitabh94 wants to merge 1 commit into
mainfrom
feat/ramp-navigate-to-buy-foundation

Conversation

@amitabh94
Copy link
Copy Markdown
Contributor

Description

Adds navigateToRampBuy as a shared imperative entry point that mirrors useRampNavigation.goToBuy (UB2 BuildQuote / token selection, eligibility modals, V1 deposit vs aggregator, override modes). Refactors useRampNavigation to delegate to that helper. Introduces app/components/UI/Ramp/navigation.ts as a small barrel for ramp navigation exports. Includes unit tests for navigateToRampBuy.

Follow-up (not in this PR): phased work such as NativeFlow hoist, sell-only aggregator routing, and removing Deposit-only paths is out of scope until those changes exist in the tree.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

Feature: Ramp buy navigation helper

  Scenario: spot-check existing ramp buy entry points
    Given a dev build with ramps enabled
    When the user opens buy from an existing ramp entry that uses useRampNavigation
    Then routing behavior matches pre-refactor UB2/V1 paths

Screenshots/Recordings

N/A (internal refactor; no intentional UI change).

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@amitabh94 amitabh94 self-assigned this May 8, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-money-movement issues related to Money Movement features label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-L labels May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-L team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant